upgrade Embark to 4.2.0 and web3 to 1.2.4 #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Sokołowski <jakub@status.im>
flexsurfer
approved these changes
Dec 19, 2019
|
tested on ios and android, and in chrome and safari works well |
|
Could not deploy Dapp at dev.dap.ps from iOS, but able to submit it on Android.
On dap.ps it's even worse actually as it says :
But dev.dap.ps works now on iOS (and Android) which is great news! Kudos @jakubgs |
|
@Serhy the "did you run out of gas" happens if you use https://dev.dap.ps/ with mainnet rather than ropsten. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've deployed the app built from this branch using
make build:devto https://dev.dap.ps/.iPad test: https://www.webpagetest.org/result/191219_W8_01859859a79ef7ba3da15d846e4da5dc/
Fixes: #16